Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-134393 / 25.04.0 / Expose IO bus configuration in the UI (by AlexKarpov98) #11671

Merged
merged 2 commits into from
Mar 6, 2025
Merged

NAS-134393 / 25.04.0 / Expose IO bus configuration in the UI (by AlexKarpov98) #11671

merged 2 commits into from
Mar 6, 2025

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Mar 5, 2025

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 6261cc39da346b6b215a33a1be1cd91043fd977c
git cherry-pick -x 71e0334b5623313aaa85b64beab8c2e41e53ceb6
git cherry-pick -x ae13d25be9cbf6e35c654729e7556cacbd2191e8
git cherry-pick -x 1ec1111ee3c03984d5c0a9f4aed9ccdfaf51a8d7
git cherry-pick -x c2e8833303fe5616820898031804c16395f71846
git cherry-pick -x 484926c1711937e4c953a2964256cb7cefa77954
git cherry-pick -x 503ab1f7b7dd056bbbfc91aee1f203020a06e9fd
git cherry-pick -x 6fbd10fee4129a1b3a4e14127daf8918c5aa8e21
git cherry-pick -x 1cc989cdbc8a6915b0a87cc2cb9bc1be5577fe97
git cherry-pick -x 23f03d213864202aa9325e50aa20f755b75679cd

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 3462726867ae0232cb1d2e1511ba14e48b6e6df2

Changes:
Instance wizard, Instance Edit Form, Instance Disks Form were updated.

Testing:
See ticket.

Preview:

NAS-134393.mov

Downstream

Affects Reasoning
Documentation IO bus configuration added

Original PR: #11633
Jira URL: https://ixsystems.atlassian.net/browse/NAS-134393

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review March 5, 2025 17:41
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner March 5, 2025 17:41
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team March 5, 2025 17:41
AlexKarpov98
AlexKarpov98 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@8d1196f). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...oot-disk-setup/change-root-disk-setup.component.ts 76.47% 4 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11671   +/-   ##
===================================================
  Coverage                    ?   83.07%           
===================================================
  Files                       ?     1654           
  Lines                       ?    59140           
  Branches                    ?     6264           
===================================================
  Hits                        ?    49133           
  Misses                      ?    10007           
  Partials                    ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexKarpov98 AlexKarpov98 merged commit 3885332 into stable/fangtooth Mar 6, 2025
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-134393-25.04.0 branch March 6, 2025 09:16
@bugclerk
Copy link
Contributor Author

bugclerk commented Mar 6, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

@bvasilenko bvasilenko Awaiting requested review from bvasilenko bvasilenko is a code owner automatically assigned from truenas/ui-team

Assignees

@AlexKarpov98 AlexKarpov98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugclerk @AlexKarpov98